Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: favor === over == in test-timers.js #8131

Closed
wants to merge 1 commit into from
Closed

test: favor === over == in test-timers.js #8131

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 16, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test timers

Description of change

Use === instead of == in pummel/test-timers.js

@Trott Trott added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. test Issues and PRs related to the tests. labels Aug 16, 2016
@addaleax
Copy link
Member

Love the PR title. ;)

LGTM… how bad would it be to do all of those in a bulk update?

@Trott Trott changed the title test: favor == over == in test-timers.js test: favor === over == in test-timers.js Aug 16, 2016
@Trott
test: favor === over == in test-timers.js
5936758 
Use `===` instead of `==` in pummel/test-timers.js
@Trott
Copy link
Member Author

Trott commented Aug 16, 2016 •
edited
Loading

@addaleax asked:

how bad would it be to do all of those in a bulk update?

Hard to say. Might be fine. Or it might be hard to review because it will be a mix of:

  • == -> ===
  • != => !==
  • == -> assert.strictEqual()
  • == -> assert.deepStrictEqual()
  • != -> assert.notStrictEqual()
  • != -> assert.notDeepStrictEqual()
  • watching out for legitimate uses of == and != that shouldn't be changed (like in assert.js)

It will probably be more straightforward in the tests than in the instances in lib.

I was pondering both doing one big PR and also going the other way and suggesting that people do individual files as a good first contribution.
¯_(ツ)_/¯

@addaleax
Copy link
Member

@Trott Mh yeah, you can probably judge that best. It just seems like a lot of overhead on your part to me. :)

CI: https://ci.nodejs.org/job/node-test-commit/4610/

@targos
Copy link
Member

targos commented Aug 17, 2016

LGTM

2 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Aug 17, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Aug 17, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 18, 2016
@Trott
test: favor === over == in test-timers.js
d52ceb4 
Use `===` instead of `==` in pummel/test-timers.js

PR-URL: nodejs#8131
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Aug 18, 2016

Landed in d52ceb4

@Trott Trott closed this Aug 18, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@Trott @evanlucas
test: favor === over == in test-timers.js
e5a8790 
Use `===` instead of `==` in pummel/test-timers.js

PR-URL: #8131
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@Trott
test: favor === over == in test-timers.js
137d10d 
Use `===` instead of `==` in pummel/test-timers.js

PR-URL: #8131
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Trott @rvagg
test: favor === over == in test-timers.js
ec442d9 
Use `===` instead of `==` in pummel/test-timers.js

PR-URL: #8131
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Trott @MylesBorins
test: favor === over == in test-timers.js
9c826be 
Use `===` instead of `==` in pummel/test-timers.js

PR-URL: #8131
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
@Trott Trott deleted the timerpummel branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @addaleax @targos @cjihrig @jasnell @MylesBorins